Re: [PATCH v4 2/3] format-patch: use enum variables

2019-10-11 Thread Junio C Hamano
Denton Liu writes: > -#define THREAD_SHALLOW 1 > -#define THREAD_DEEP 2 > -static int thread; > +enum thread_level { > + THREAD_UNSET, > + THREAD_SHALLOW, > + THREAD_DEEP > +}; > +static enum thread_level thread; As the assignment of values do not change, this is a safe conversion ev

[PATCH v4 2/3] format-patch: use enum variables

2019-10-11 Thread Denton Liu
Before, `thread` and `config_cover_letter` were defined as ints even though they behaved as enums. Define actual enums and change these variables to use these new definitions. Signed-off-by: Denton Liu --- builtin/log.c | 30 +- 1 file changed, 17 insertions(+), 13 de