Re: [PATCH v4 2/3] commit-graph: fix buffer read-overflow

2019-01-15 Thread Josh Steadmon
On 2019.01.12 11:57, SZEDER Gábor wrote: > On Thu, Dec 13, 2018 at 11:43:57AM -0800, Josh Steadmon wrote: > > diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh > > index 5fe21db99f..a1b5a75882 100755 > > --- a/t/t5318-commit-graph.sh > > +++ b/t/t5318-commit-graph.sh > > @@ -366,21 +36

Re: [PATCH v4 2/3] commit-graph: fix buffer read-overflow

2019-01-12 Thread SZEDER Gábor
On Thu, Dec 13, 2018 at 11:43:57AM -0800, Josh Steadmon wrote: > diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh > index 5fe21db99f..a1b5a75882 100755 > --- a/t/t5318-commit-graph.sh > +++ b/t/t5318-commit-graph.sh > @@ -366,21 +366,26 @@ GRAPH_OCTOPUS_DATA_OFFSET=$(($GRAPH_COMMIT_DA

[PATCH v4 2/3] commit-graph: fix buffer read-overflow

2018-12-13 Thread Josh Steadmon
fuzz-commit-graph identified a case where Git will read past the end of a buffer containing a commit graph if the graph's header has an incorrect chunk count. A simple bounds check in parse_commit_graph() prevents this. Signed-off-by: Josh Steadmon --- commit-graph.c | 14 --