On 08/08/18 10:39, Eric Sunshine wrote:
> On Tue, Aug 7, 2018 at 5:35 AM Phillip Wood wrote:
>> Single quotes should be escaped as \' not \\'. The bad quoting breaks
>> the interactive version of 'rebase --root' (which is used when there
>> is no '--onto' even if the user does not specify --intera
Hi Eric
On 08/08/18 09:43, Eric Sunshine wrote:
> On Tue, Aug 7, 2018 at 9:54 AM Phillip Wood wrote:
>> On 07/08/18 11:23, Eric Sunshine wrote:
>>> On Tue, Aug 7, 2018 at 5:35 AM Phillip Wood
>>> wrote:
+ if (n > 0 && s[n] != '\'')
+ return 1;
>>>
>>> To be "techni
Hi Junio
On 08/08/18 17:01, Junio C Hamano wrote:
> Eric Sunshine writes:
>
>> What does concern me is that read_env_script() doesn't seem to care
>> about such a malformed file; it doesn't do any validation at all.
>> Contrast that with read_author_ident() which is pretty strict about
>> the con
Eric Sunshine writes:
> What does concern me is that read_env_script() doesn't seem to care
> about such a malformed file; it doesn't do any validation at all.
> Contrast that with read_author_ident() which is pretty strict about
> the content it expects to find in the file. So, it might make sen
On Tue, Aug 7, 2018 at 5:35 AM Phillip Wood wrote:
> Single quotes should be escaped as \' not \\'. The bad quoting breaks
> the interactive version of 'rebase --root' (which is used when there
> is no '--onto' even if the user does not specify --interactive) for
> authors that contain "'" as sq_d
On Tue, Aug 7, 2018 at 9:54 AM Phillip Wood wrote:
> On 07/08/18 11:23, Eric Sunshine wrote:
> > On Tue, Aug 7, 2018 at 5:35 AM Phillip Wood
> > wrote:
> >> + if (n > 0 && s[n] != '\'')
> >> + return 1;
> >
> > To be "technically correct", I think the condition in the 'if'
>
Hi Eric
On 07/08/18 11:23, Eric Sunshine wrote:
> On Tue, Aug 7, 2018 at 5:35 AM Phillip Wood wrote:
>> - Reverted the implementation to v2 with more robust detection of the
>>missing "'" on the last line of the author script based on a
>>suggestion by Eric. This means that t
On Tue, Aug 7, 2018 at 5:35 AM Phillip Wood wrote:
> - Reverted the implementation to v2 with more robust detection of the
>missing "'" on the last line of the author script based on a
>suggestion by Eric. This means that this series needs to progress
>closely with Eri
From: Phillip Wood
Single quotes should be escaped as \' not \\'. The bad quoting breaks
the interactive version of 'rebase --root' (which is used when there
is no '--onto' even if the user does not specify --interactive) for
authors that contain "'" as sq_dequote() called by read_author_ident()
9 matches
Mail list logo
