Re: [PATCH v4 2/2] commit-tree: add missing --gpg-sign flag

2019-01-22 Thread Martin Ågren
On Tue, 22 Jan 2019 at 20:07, Junio C Hamano wrote: > > Martin Ågren writes: > > >> + echo 11 | git commit-tree --gpg-sign HEAD^{tree} >oid && > >> + test_line_count = 1 oid && > >> + git tag eleventh-signed $(cat oid) && > >> +... > > Let's see if there any opinions from others

Re: [PATCH v4 2/2] commit-tree: add missing --gpg-sign flag

2019-01-22 Thread Junio C Hamano
Martin Ågren writes: >> + echo 11 | git commit-tree --gpg-sign HEAD^{tree} >oid && >> + test_line_count = 1 oid && >> + git tag eleventh-signed $(cat oid) && >> +... > Let's see if there any opinions from others about this more verbose > construction, vs placing the oid in a var

Re: [PATCH v4 2/2] commit-tree: add missing --gpg-sign flag

2019-01-20 Thread Martin Ågren
Hi Brandon, On Sun, 20 Jan 2019 at 00:24, Brandon Richardson wrote: > # explicit -S of course must sign. > echo 10 | git commit-tree -S HEAD^{tree} >oid && > test_line_count = 1 oid && > - git tag tenth-signed $(cat oid) > + git tag tenth-signed $(cat oid) && >

[PATCH v4 2/2] commit-tree: add missing --gpg-sign flag

2019-01-19 Thread Brandon Richardson
Add --gpg-sign option in commit-tree, which was documented, but not implemented, in 55ca3f99ae. Add tests for the --gpg-sign option. Signed-off-by: Brandon Richardson --- builtin/commit-tree.c| 8 +++- t/t7510-signed-commit.sh | 15 --- 2 files changed, 19 insertions(+), 4 d