Re: [PATCH v4 1/3] clone: do not include authentication data in guessed dir

On Fri, Aug 07, 2015 at 01:45:54PM -0700, Junio C Hamano wrote: > Patrick Steinhardt writes: > > > On Wed, Aug 05, 2015 at 12:41:27PM -0700, Junio C Hamano wrote: > >> Junio C Hamano writes: > >> > >> > For completeness, here is what I think the end result (together with > >> > Peff's series) o

Re: [PATCH v4 1/3] clone: do not include authentication data in guessed dir

Patrick Steinhardt writes: > On Wed, Aug 05, 2015 at 12:41:27PM -0700, Junio C Hamano wrote: >> Junio C Hamano writes: >> >> > For completeness, here is what I think the end result (together with >> > Peff's series) of the test should look like. >> > ... >> > Note that ssh://user:passw@rd@host:

Re: [PATCH v4 1/3] clone: do not include authentication data in guessed dir

On Wed, Aug 05, 2015 at 12:41:27PM -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > > For completeness, here is what I think the end result (together with > > Peff's series) of the test should look like. > > ... > > Note that ssh://user:passw@rd@host:1234/ and user:passw@rd@host:/ > > te

Re: [PATCH v4 1/3] clone: do not include authentication data in guessed dir

Junio C Hamano writes: > For completeness, here is what I think the end result (together with > Peff's series) of the test should look like. > ... > Note that ssh://user:passw@rd@host:1234/ and user:passw@rd@host:/ > tests fail for the same reason (finding @ should be greedy, I think). And I thi

Re: [PATCH v4 1/3] clone: do not include authentication data in guessed dir

Junio C Hamano writes: > Perhaps add > > "test_clone_dir ssh://user:passw@rd@host/ host" > > here? How is this expected to be parsed? For completeness, here is what I think the end result (together with Peff's series) of the test should look like. The first hunk is merely style. We could drop

Re: [PATCH v4 1/3] clone: do not include authentication data in guessed dir

Patrick Steinhardt writes: > If the URI contains authentication data and the URI's path > component is empty we fail to guess a sensible directory name. > E.g. cloning a repository 'ssh://user:passw...@example.com/' we > guess a directory name 'passw...@example.com' where we would want > the host

[PATCH v4 1/3] clone: do not include authentication data in guessed dir

If the URI contains authentication data and the URI's path component is empty we fail to guess a sensible directory name. E.g. cloning a repository 'ssh://user:passw...@example.com/' we guess a directory name 'passw...@example.com' where we would want the hostname only, e.g. 'example.com'. Fix thi