Re: [PATCH v4 1/2] lib-proto-disable: variable name fix

2016-11-08 Thread Junio C Hamano
Jacob Keller writes: > On Mon, Nov 7, 2016 at 12:48 PM, Jeff King wrote: >> It's possible that I'm overly picky about my commit messages, but that >> does not stop me from trying to train an army of picky-commit-message >> clones. :) >> >> -Peff > > You're not the only one ;) Somebody seems to

Re: [PATCH v4 1/2] lib-proto-disable: variable name fix

2016-11-07 Thread Jacob Keller
On Mon, Nov 7, 2016 at 12:48 PM, Jeff King wrote: > It's possible that I'm overly picky about my commit messages, but that > does not stop me from trying to train an army of picky-commit-message > clones. :) > > -Peff You're not the only one ;) Regards, Jake

Re: [PATCH v4 1/2] lib-proto-disable: variable name fix

2016-11-07 Thread Jeff King
On Mon, Nov 07, 2016 at 12:40:28PM -0800, Brandon Williams wrote: > On 11/07, Jeff King wrote: > > On Mon, Nov 07, 2016 at 11:35:22AM -0800, Brandon Williams wrote: > > > > > Small fix to use '$desc' instead of '$1' in lib-proto-disable.sh. > > > > Even for a trivial fixup like this, I think it'

Re: [PATCH v4 1/2] lib-proto-disable: variable name fix

2016-11-07 Thread Brandon Williams
On 11/07, Jeff King wrote: > On Mon, Nov 07, 2016 at 11:35:22AM -0800, Brandon Williams wrote: > > > Small fix to use '$desc' instead of '$1' in lib-proto-disable.sh. > > Even for a trivial fixup like this, I think it's good to say why. > Because what seems trivial and obvious to you while workin

Re: [PATCH v4 1/2] lib-proto-disable: variable name fix

2016-11-07 Thread Jeff King
On Mon, Nov 07, 2016 at 11:35:22AM -0800, Brandon Williams wrote: > Small fix to use '$desc' instead of '$1' in lib-proto-disable.sh. Even for a trivial fixup like this, I think it's good to say why. Because what seems trivial and obvious to you while working on the patch may not be so to a revie

[PATCH v4 1/2] lib-proto-disable: variable name fix

2016-11-07 Thread Brandon Williams
Small fix to use '$desc' instead of '$1' in lib-proto-disable.sh. Signed-off-by: Brandon Williams --- t/lib-proto-disable.sh | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/t/lib-proto-disable.sh b/t/lib-proto-disable.sh index b0917d9..be88e9a 100644 --- a/t/lib-