Re: [PATCH v4 1/2] gitk: write only changed configuration variables

2015-03-02 Thread Max Kirillov
On Mon, Mar 02, 2015 at 10:47:30AM +1100, Paul Mackerras wrote: > On Mon, Nov 10, 2014 at 12:20:01AM +0200, Max Kirillov wrote: >> +lappend views_modified_names $current_viewname($v) > > This view_modified_names variable doesn't seem to be used anywhere. > If you don't mind me taking o

Re: [PATCH v4 1/2] gitk: write only changed configuration variables

2015-03-01 Thread Paul Mackerras
On Mon, Nov 10, 2014 at 12:20:01AM +0200, Max Kirillov wrote: > When gitk contains some changed parameter, and there is existing > instance of gitk where the parameter is still old, it is reverted to > that old value when the instance exits. > > Instead, store a parameter in config only it is has

[PATCH v4 1/2] gitk: write only changed configuration variables

2014-11-09 Thread Max Kirillov
When gitk contains some changed parameter, and there is existing instance of gitk where the parameter is still old, it is reverted to that old value when the instance exits. Instead, store a parameter in config only it is has been modified in the exiting instance. Otherwise, preserve the value whi