Re: [PATCH v4 09/12] Add several uses of get_object_hash.

2015-11-20 Thread brian m. carlson
On Fri, Nov 20, 2015 at 06:38:30AM -0500, Jeff King wrote: > On Tue, Nov 10, 2015 at 02:22:27AM +, brian m. carlson wrote: > > > diff --git a/patch-ids.c b/patch-ids.c > > index bf81b923..83229a0d 100644 > > --- a/patch-ids.c > > +++ b/patch-ids.c > > @@ -8,10 +8,10 @@ static int commit_patch_

Re: [PATCH v4 09/12] Add several uses of get_object_hash.

2015-11-20 Thread Jeff King
On Tue, Nov 10, 2015 at 02:22:27AM +, brian m. carlson wrote: > diff --git a/patch-ids.c b/patch-ids.c > index bf81b923..83229a0d 100644 > --- a/patch-ids.c > +++ b/patch-ids.c > @@ -8,10 +8,10 @@ static int commit_patch_id(struct commit *commit, struct > diff_options *options, >

[PATCH v4 09/12] Add several uses of get_object_hash.

2015-11-09 Thread brian m. carlson
Convert most instances where the sha1 member of struct object is dereferenced to use get_object_hash. Most instances that are passed to functions that have versions taking struct object_id, such as get_sha1_hex/get_oid_hex, or instances that can be trivially converted to use struct object_id inste