Re: [PATCH v4 08/19] parse-option: rename parse_opt_with_commit()

2015-06-22 Thread Karthik Nayak
On Mon, Jun 22, 2015 at 9:57 PM, Junio C Hamano wrote: > On Mon, Jun 22, 2015 at 8:38 AM, Karthik Nayak wrote: >> On Mon, Jun 22, 2015 at 6:34 AM, Junio C Hamano wrote: >>> On Sun, Jun 21, 2015 at 1:48 PM, Karthik Nayak >>> wrote: Rename parse_opt_with_commit() to parse_opt_commit_object_

Re: [PATCH v4 08/19] parse-option: rename parse_opt_with_commit()

2015-06-22 Thread Junio C Hamano
On Mon, Jun 22, 2015 at 8:38 AM, Karthik Nayak wrote: > On Mon, Jun 22, 2015 at 6:34 AM, Junio C Hamano wrote: >> On Sun, Jun 21, 2015 at 1:48 PM, Karthik Nayak wrote: >>> Rename parse_opt_with_commit() to parse_opt_commit_object_name() >>> to show that it can be used to obtain a list of commits

Re: [PATCH v4 08/19] parse-option: rename parse_opt_with_commit()

2015-06-22 Thread Karthik Nayak
On Mon, Jun 22, 2015 at 6:34 AM, Junio C Hamano wrote: > On Sun, Jun 21, 2015 at 1:48 PM, Karthik Nayak wrote: >> Rename parse_opt_with_commit() to parse_opt_commit_object_name() >> to show that it can be used to obtain a list of commits and is >> not constricted to usage of '--contains' option.

Re: [PATCH v4 08/19] parse-option: rename parse_opt_with_commit()

2015-06-21 Thread Junio C Hamano
On Sun, Jun 21, 2015 at 1:48 PM, Karthik Nayak wrote: > Rename parse_opt_with_commit() to parse_opt_commit_object_name() > to show that it can be used to obtain a list of commits and is > not constricted to usage of '--contains' option. I think that is a brilliant idea, but unlike the other funct

[PATCH v4 08/19] parse-option: rename parse_opt_with_commit()

2015-06-21 Thread Karthik Nayak
Rename parse_opt_with_commit() to parse_opt_commit_object_name() to show that it can be used to obtain a list of commits and is not constricted to usage of '--contains' option. Mentored-by: Christian Couder Mentored-by: Matthieu Moy Signed-off-by: Karthik Nayak --- builtin/branch.c | 4 ++--