Re: [PATCH v4 07/11] pack-objects: refer to delta objects by index instead of pointer

2018-03-16 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > These delta pointers always point to elements in the objects[] array > in packing_data struct. We can only hold maximum 4GB of those objects 4GB, as in "number of bytes"? Or "We can hold 4 billion or so of those objects"? > because the array length, nr_objects,

[PATCH v4 07/11] pack-objects: refer to delta objects by index instead of pointer

2018-03-16 Thread Nguyễn Thái Ngọc Duy
These delta pointers always point to elements in the objects[] array in packing_data struct. We can only hold maximum 4GB of those objects because the array length, nr_objects, is uint32_t. We could use uint32_t indexes to address these elements instead of pointers. On 64-bit architecture (8 bytes