Re: [PATCH v4 06/15] submodule--helper: die on config error when cloning module

2016-02-08 Thread Patrick Steinhardt
On Tue, Feb 02, 2016 at 01:45:50PM -0500, Eric Sunshine wrote: > On Tue, Feb 2, 2016 at 6:51 AM, Patrick Steinhardt wrote: > > When setting the 'core.worktree' option for a newly cloned > > submodule we ignore the return value of `git_config_set_in_file`. > > As this leaves the submodule in an inc

Re: [PATCH v4 06/15] submodule--helper: die on config error when cloning module

2016-02-02 Thread Eric Sunshine
On Tue, Feb 2, 2016 at 6:51 AM, Patrick Steinhardt wrote: > When setting the 'core.worktree' option for a newly cloned > submodule we ignore the return value of `git_config_set_in_file`. > As this leaves the submodule in an inconsistent state, we instaed > we want to inform the user that something

[PATCH v4 06/15] submodule--helper: die on config error when cloning module

2016-02-02 Thread Patrick Steinhardt
When setting the 'core.worktree' option for a newly cloned submodule we ignore the return value of `git_config_set_in_file`. As this leaves the submodule in an inconsistent state, we instaed we want to inform the user that something has gone wrong by printing an error and aborting the program. Sig