Re: [PATCH v4 05/35] upload-pack: factor out processing lines

2018-03-12 Thread Brandon Williams
On 03/12, Brandon Williams wrote: > On 03/01, Junio C Hamano wrote: > > Brandon Williams writes: > > > > > Factor out the logic for processing shallow, deepen, deepen_since, and > > > deepen_not lines into their own functions to simplify the > > > 'receive_needs()' function in addition to making

Re: [PATCH v4 05/35] upload-pack: factor out processing lines

2018-03-12 Thread Brandon Williams
On 03/01, Junio C Hamano wrote: > Brandon Williams writes: > > > Factor out the logic for processing shallow, deepen, deepen_since, and > > deepen_not lines into their own functions to simplify the > > 'receive_needs()' function in addition to making it easier to reuse some > > of this logic when

Re: [PATCH v4 05/35] upload-pack: factor out processing lines

2018-03-01 Thread Junio C Hamano
Brandon Williams writes: > Factor out the logic for processing shallow, deepen, deepen_since, and > deepen_not lines into their own functions to simplify the > 'receive_needs()' function in addition to making it easier to reuse some > of this logic when implementing protocol_v2. These little fun

[PATCH v4 05/35] upload-pack: factor out processing lines

2018-02-28 Thread Brandon Williams
Factor out the logic for processing shallow, deepen, deepen_since, and deepen_not lines into their own functions to simplify the 'receive_needs()' function in addition to making it easier to reuse some of this logic when implementing protocol_v2. Signed-off-by: Brandon Williams --- upload-pack.c