Re: [PATCH v4 00/34] Add directory rename detection to git

2017-12-13 Thread Junio C Hamano
Ramsay Jones writes: > On 13/12/17 01:06, Junio C Hamano wrote: > >> We may probably want to redirect the output of underlying grep to >> /dev/null in test_i18ngrep to make this kind of misuse easier to >> spot. > > I have test-suite failures on the 'pu' branch for t4151-am-abort.sh > (#3 and #6)

Re: [PATCH v4 00/34] Add directory rename detection to git

2017-12-13 Thread Ramsay Jones
On 13/12/17 01:06, Junio C Hamano wrote: > Elijah Newren writes: > >> This patchset introduces directory rename detection to merge-recursive. > > The use of negated form of test_i18ngrep in these patches are all > wrong. Because the helper must say "even though the string does not > match (do

Re: [PATCH v4 00/34] Add directory rename detection to git

2017-12-13 Thread Elijah Newren
On Tue, Dec 12, 2017 at 6:01 PM, Junio C Hamano wrote: > OK, it seems that I managed to make this test pass under poison build > (see https://travis-ci.org/git/git/jobs/315658242) > > Please check > https://github.com/git/git/commit/e5c5e24ad91a75b5a70c056fe6c6e3bfb55b56fc > and sprinkle its fix

Re: [PATCH v4 00/34] Add directory rename detection to git

2017-12-12 Thread Junio C Hamano
OK, it seems that I managed to make this test pass under poison build (see https://travis-ci.org/git/git/jobs/315658242) Please check https://github.com/git/git/commit/e5c5e24ad91a75b5a70c056fe6c6e3bfb55b56fc and sprinkle its fix to whichever original commits in the series that need fixing. Than

Re: [PATCH v4 00/34] Add directory rename detection to git

2017-12-12 Thread Junio C Hamano
Elijah Newren writes: > This patchset introduces directory rename detection to merge-recursive. The use of negated form of test_i18ngrep in these patches are all wrong. Because the helper must say "even though the string does not match (does match), the test expects it to match (does not match)

[PATCH v4 00/34] Add directory rename detection to git

2017-11-28 Thread Elijah Newren
This patchset introduces directory rename detection to merge-recursive. See https://public-inbox.org/git/20171110190550.27059-1-new...@gmail.com/ for the first series (including design considerations, etc.), and follow-up series can be found at https://public-inbox.org/git/20171120220209.15111