Re: [PATCH v4 00/15] Remove submodule from files-backend.c

2017-02-20 Thread Duy Nguyen
On Mon, Feb 20, 2017 at 7:42 PM, Michael Haggerty wrote: > On 02/18/2017 02:32 PM, Nguyễn Thái Ngọc Duy wrote: >> v4: > > I very much like the direction of this patch series. I reviewed the > design pretty carefully and left some comments about it, and skimmed > through the code changes. But I hav

Re: [PATCH v4 00/15] Remove submodule from files-backend.c

2017-02-20 Thread Michael Haggerty
On 02/18/2017 02:32 PM, Nguyễn Thái Ngọc Duy wrote: > v4: I very much like the direction of this patch series. I reviewed the design pretty carefully and left some comments about it, and skimmed through the code changes. But I haven't yet reviewed the code in detail. I'll wait for your reaction to

[PATCH v4 00/15] Remove submodule from files-backend.c

2017-02-18 Thread Nguyễn Thái Ngọc Duy
v4: - is based on master+mh/ref-remove-empty-directory+mh/submodule-hash instead of mh/submodule-hash alone. It could merge with pu cleanly. - 06/16 from v5, "correct is_per_worktree_ref", is removed. The "remove the use of git_path" patch is updated to handle it correctly even without