Re: [PATCH v4 00/12] ref-filter: use parsing functions

2016-02-04 Thread Eric Sunshine
Karthik Nayak writes: > This series cleans up populate_value() in ref-filter, by moving out > the parsing part of atoms to separate parsing functions. This ensures > that parsing is only done once and also improves the modularity of the > code. > > v1: http://thread.gmane.org/gmane.comp.version-co

Re: [PATCH v4 00/12] ref-filter: use parsing functions

2016-02-01 Thread Karthik Nayak
On Tue, Feb 2, 2016 at 6:07 AM, Eric Sunshine wrote: > On Mon, Feb 1, 2016 at 5:25 PM, Junio C Hamano wrote: >> Karthik Nayak writes: >> >>> This series cleans up populate_value() in ref-filter, by moving out >>> the parsing part of atoms to separate parsing functions. This ensures >>> that pars

Re: [PATCH v4 00/12] ref-filter: use parsing functions

2016-02-01 Thread Eric Sunshine
On Mon, Feb 1, 2016 at 5:25 PM, Junio C Hamano wrote: > Karthik Nayak writes: > >> This series cleans up populate_value() in ref-filter, by moving out >> the parsing part of atoms to separate parsing functions. This ensures >> that parsing is only done once and also improves the modularity of the

Re: [PATCH v4 00/12] ref-filter: use parsing functions

2016-02-01 Thread Junio C Hamano
Karthik Nayak writes: > This series cleans up populate_value() in ref-filter, by moving out > the parsing part of atoms to separate parsing functions. This ensures > that parsing is only done once and also improves the modularity of the > code. > > v1: http://thread.gmane.org/gmane.comp.version-c

[PATCH v4 00/12] ref-filter: use parsing functions

2016-01-31 Thread Karthik Nayak
This series cleans up populate_value() in ref-filter, by moving out the parsing part of atoms to separate parsing functions. This ensures that parsing is only done once and also improves the modularity of the code. v1: http://thread.gmane.org/gmane.comp.version-control.git/281180 v2: http://thread