Re: [PATCH v4 0/5] Kill manual ref parsing code in worktree.c

2017-04-21 Thread Michael Haggerty
On 04/14/2017 03:40 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> v4 adds a new patch, 2/5, which makes the hashmap related functions in >> refs.c generic, so I could add a new map for worktree ref stores and >> not abuse submodule hashmap. >> >> I mentioned about moving these ha

Re: [PATCH v4 0/5] Kill manual ref parsing code in worktree.c

2017-04-16 Thread Junio C Hamano
Duy Nguyen writes: > This is embarassing. I worked on and off on this series over a long > period of time. I guess at the end I thought everything was ok "since > the last time" and just sent it away without realizing I hadn't > actually run the test suite, because it does fail here, now. > > Thi

Re: [PATCH v4 0/5] Kill manual ref parsing code in worktree.c

2017-04-14 Thread Duy Nguyen
On Thu, Apr 13, 2017 at 07:02:22PM -0700, Junio C Hamano wrote: > Oops, I shouldn't have done that. When applied on top of the > files-backend thing (or have you updated that one and is my tree > lacking it???), this breaks quite a few tests. > > t0001#41 dumps core from "git worktree add ../link

Re: [PATCH v4 0/5] Kill manual ref parsing code in worktree.c

2017-04-13 Thread Junio C Hamano
Junio C Hamano writes: > Nguyễn Thái Ngọc Duy writes: > >> v4 adds a new patch, 2/5, which makes the hashmap related functions in >> refs.c generic, so I could add a new map for worktree ref stores and >> not abuse submodule hashmap. >> >> I mentioned about moving these hashmap back to submodul

Re: [PATCH v4 0/5] Kill manual ref parsing code in worktree.c

2017-04-13 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > v4 adds a new patch, 2/5, which makes the hashmap related functions in > refs.c generic, so I could add a new map for worktree ref stores and > not abuse submodule hashmap. > > I mentioned about moving these hashmap back to submodule.c and > worktree.c where it can

[PATCH v4 0/5] Kill manual ref parsing code in worktree.c

2017-04-04 Thread Nguyễn Thái Ngọc Duy
v4 adds a new patch, 2/5, which makes the hashmap related functions in refs.c generic, so I could add a new map for worktree ref stores and not abuse submodule hashmap. I mentioned about moving these hashmap back to submodule.c and worktree.c where it can map more than just ref stores (in worktree