Re: [PATCH v4 0/4] Test oidmap

2019-06-19 Thread Christian Couder
On Thu, Jun 20, 2019 at 12:09 AM Jeff King wrote: > > On Wed, Jun 19, 2019 at 05:42:13PM -0400, Jeff King wrote: > > > I do think that sha1hash() will eventually go away in favor of > > oidhash(), but we can approach that separately, and convert oidmap along > > with everyone else. Yeah, deprecat

Re: [PATCH v4 0/4] Test oidmap

2019-06-19 Thread Jeff King
On Wed, Jun 19, 2019 at 05:42:13PM -0400, Jeff King wrote: > I do think that sha1hash() will eventually go away in favor of > oidhash(), but we can approach that separately, and convert oidmap along > with everyone else. > > It looks like we are close to being able to do that now. Grepping for >

Re: [PATCH v4 0/4] Test oidmap

2019-06-19 Thread Jeff King
On Sat, Jun 15, 2019 at 12:06:58PM +0200, Christian Couder wrote: > Unlike hashmap that has t/helper/test-hashmap.c and t/t0011-hashmap.sh > oidmap has no specific test. The goal of this small patch series is to > change that and also improve oidmap a bit while at it. > > Changes compared to V3 a

[PATCH v4 0/4] Test oidmap

2019-06-15 Thread Christian Couder
Unlike hashmap that has t/helper/test-hashmap.c and t/t0011-hashmap.sh oidmap has no specific test. The goal of this small patch series is to change that and also improve oidmap a bit while at it. Changes compared to V3 are the following: - removed "hash" command in test-oidmap.c and "hash" tes