Re: [PATCH v4 0/4] Introduce diff.submodule

2012-11-16 Thread Ramkumar Ramachandra
Jeff King wrote: > It may be worth squashing this test into patch 3: Looks good. Thanks. > BTW, while writing the test, I noticed two minor nits with your tests: > > 1. They can use test_config, which is simpler (you do not need to > unset yourself after the test) and safer (the unset hap

Re: [PATCH v4 0/4] Introduce diff.submodule

2012-11-15 Thread Jeff King
On Thu, Nov 15, 2012 at 08:25:26AM -0800, Jeff King wrote: > > Thanks, this version looks good to me. > > Oh wait. I did not look closely enough. The point was to move the option > parser _out_ of git_diff_ui_config into git_diff_basic_config, so that > it only triggers for porcelain, not plumbin

Re: [PATCH v4 0/4] Introduce diff.submodule

2012-11-15 Thread Jeff King
On Thu, Nov 15, 2012 at 08:23:34AM -0800, Jeff King wrote: > On Tue, Nov 13, 2012 at 09:12:43PM +0530, Ramkumar Ramachandra wrote: > > > v1 is here: > > http://mid.gmane.org/1349196670-2844-1-git-send-email-artag...@gmail.com > > v2 is here: > > http://mid.gmane.org/1351766630-4837-1-git-send-e

Re: [PATCH v4 0/4] Introduce diff.submodule

2012-11-15 Thread Jeff King
On Tue, Nov 13, 2012 at 09:12:43PM +0530, Ramkumar Ramachandra wrote: > v1 is here: > http://mid.gmane.org/1349196670-2844-1-git-send-email-artag...@gmail.com > v2 is here: > http://mid.gmane.org/1351766630-4837-1-git-send-email-artag...@gmail.com > v3 is here: > http://mid.gmane.org/1352653146

[PATCH v4 0/4] Introduce diff.submodule

2012-11-13 Thread Ramkumar Ramachandra
v1 is here: http://mid.gmane.org/1349196670-2844-1-git-send-email-artag...@gmail.com v2 is here: http://mid.gmane.org/1351766630-4837-1-git-send-email-artag...@gmail.com v3 is here: http://mid.gmane.org/1352653146-3932-1-git-send-email-artag...@gmail.com This version was prepared in response to