Re: [PATCH v4 0/3] Add commit-graph fuzzer and fix buffer overflow

2018-12-26 Thread Junio C Hamano
Jeff King writes: > On Tue, Dec 18, 2018 at 01:05:51PM -0800, Josh Steadmon wrote: > >> On 2018.12.18 12:35, Jeff King wrote: >> > On Thu, Dec 13, 2018 at 11:43:55AM -0800, Josh Steadmon wrote: >> > >> > > Add a new fuzz test for the commit graph and fix a buffer read-overflow >> > > that it dis

Re: [PATCH v4 0/3] Add commit-graph fuzzer and fix buffer overflow

2018-12-20 Thread Jeff King
On Thu, Dec 20, 2018 at 08:35:57PM +0100, Johannes Schindelin wrote: > > I do wonder if we'll run into problems on Windows, though. > > As long as we're talking about Unix shell scripts, /dev/zero should be > fine, as we are essentially running in a variant of Cygwin. > > If you try to pass /dev

Re: [PATCH v4 0/3] Add commit-graph fuzzer and fix buffer overflow

2018-12-20 Thread Johannes Schindelin
Hi Peff, On Wed, 19 Dec 2018, Jeff King wrote: > On Tue, Dec 18, 2018 at 01:05:51PM -0800, Josh Steadmon wrote: > > > On 2018.12.18 12:35, Jeff King wrote: > > > On Thu, Dec 13, 2018 at 11:43:55AM -0800, Josh Steadmon wrote: > > > > > > > Add a new fuzz test for the commit graph and fix a buff

Re: [PATCH v4 0/3] Add commit-graph fuzzer and fix buffer overflow

2018-12-19 Thread Jeff King
On Tue, Dec 18, 2018 at 01:05:51PM -0800, Josh Steadmon wrote: > On 2018.12.18 12:35, Jeff King wrote: > > On Thu, Dec 13, 2018 at 11:43:55AM -0800, Josh Steadmon wrote: > > > > > Add a new fuzz test for the commit graph and fix a buffer read-overflow > > > that it discovered. Additionally, fix t

Re: [PATCH v4 0/3] Add commit-graph fuzzer and fix buffer overflow

2018-12-18 Thread Josh Steadmon
On 2018.12.18 12:35, Jeff King wrote: > On Thu, Dec 13, 2018 at 11:43:55AM -0800, Josh Steadmon wrote: > > > Add a new fuzz test for the commit graph and fix a buffer read-overflow > > that it discovered. Additionally, fix the Makefile instructions for > > building fuzzers. > > > > Changes since

Re: [PATCH v4 0/3] Add commit-graph fuzzer and fix buffer overflow

2018-12-18 Thread Jeff King
On Thu, Dec 13, 2018 at 11:43:55AM -0800, Josh Steadmon wrote: > Add a new fuzz test for the commit graph and fix a buffer read-overflow > that it discovered. Additionally, fix the Makefile instructions for > building fuzzers. > > Changes since V3: > * Improve portability of the new test functi

[PATCH v4 0/3] Add commit-graph fuzzer and fix buffer overflow

2018-12-13 Thread Josh Steadmon
Add a new fuzz test for the commit graph and fix a buffer read-overflow that it discovered. Additionally, fix the Makefile instructions for building fuzzers. Changes since V3: * Improve portability of the new test functionality. * Fix broken &&-chains in tests. Changes since V2: * Avoid poi