Re: [PATCH v4] transport-helper: report errors properly

2013-04-10 Thread Jeff King
On Wed, Apr 10, 2013 at 04:13:20PM -0700, rh wrote: > > +++ b/transport-helper.c > > @@ -54,7 +54,7 @@ static int recvline_fh(FILE *helper, struct strbuf > > *buffer) if (strbuf_getline(buffer, helper, '\n') == EOF) { > > if (debug) > > fprintf(stderr, "Debug: Remot

Re: [PATCH v4] transport-helper: report errors properly

2013-04-09 Thread Jeff King
On Tue, Apr 09, 2013 at 11:38:05PM +0200, Thomas Rast wrote: > Two out of six of these loops quit within 1 and 2 iterations, > respectively, both with an error along the lines of: > > expecting success: > (GIT_REMOTE_TESTGIT_FAILURE=1 && > export GIT_REMOTE_TESTGIT_FAILURE

Re: [PATCH v4] transport-helper: report errors properly

2013-04-09 Thread Thomas Rast
Felipe Contreras writes: > If a push fails because the remote-helper died (with fast-export), the > user won't see any error message. So let's add one. > > At the same time lets add tests to ensure this error is reported, and > while we are at it, check the error from fast-import [...] > +# We sl

Re: [PATCH v4] transport-helper: report errors properly

2013-04-08 Thread Jeff King
On Mon, Apr 08, 2013 at 11:20:15AM -0700, Sverre Rabbelier wrote: > On Mon, Apr 8, 2013 at 7:40 AM, Felipe Contreras > wrote: > > + die("Reading from remote helper failed"); > > Does the user know what a remote helper is? Could we point them at > some helpful docs in case they don'

Re: [PATCH v4] transport-helper: report errors properly

2013-04-08 Thread Jeff King
On Mon, Apr 08, 2013 at 09:40:04AM -0500, Felipe Contreras wrote: > If a push fails because the remote-helper died (with fast-export), the > user won't see any error message. So let's add one. > > At the same time lets add tests to ensure this error is reported, and > while we are at it, check th

Re: [PATCH v4] transport-helper: report errors properly

2013-04-08 Thread Sverre Rabbelier
On Mon, Apr 8, 2013 at 7:40 AM, Felipe Contreras wrote: > + die("Reading from remote helper failed"); Does the user know what a remote helper is? Could we point them at some helpful docs in case they don't? -- Cheers, Sverre Rabbelier -- To unsubscribe from this list: send the lin

[PATCH v4] transport-helper: report errors properly

2013-04-08 Thread Felipe Contreras
If a push fails because the remote-helper died (with fast-export), the user won't see any error message. So let's add one. At the same time lets add tests to ensure this error is reported, and while we are at it, check the error from fast-import Suggested-by: Jeff King Signed-off-by: Felipe Cont