Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit

2017-05-16 Thread 赵小强
> 在 2017年5月17日,07:49,Junio C Hamano 写道: > > Junio C Hamano writes: > >> xiaoqiang zhao writes: >> ... >>> Note: >>> Re-authentication will happen every $ messages, so it >>> will be much more acceptable if you use some form of credential helper >>> (e.g. the 'sendemail.smtppass' config opt

Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit

2017-05-16 Thread 赵小强
在 2017年5月17日,01:43,Ævar Arnfjörð Bjarmason 写道: >>> Regards >>> Jan >> >> Thank you for reporting this,I will take a look . > > You just need to initialize the variables you're using, see e.g. these > existing ones: > >my ($quiet, $dry_run) = (0, 0); > > Just do the same for the ones you

Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit

2017-05-16 Thread Junio C Hamano
Junio C Hamano writes: > xiaoqiang zhao writes: > ... >> Note: >>Re-authentication will happen every $ messages, so it >> will be much more acceptable if you use some form of credential helper >> (e.g. the 'sendemail.smtppass' config option), otherwise you will have >> to retype password eve

Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit

2017-05-16 Thread Ævar Arnfjörð Bjarmason
On Tue, May 16, 2017 at 3:55 PM, 赵小强 wrote: > > >> 在 2017年5月16日,20:10,Jan Viktorin 写道: >> >> Hello, >> >> with this patch applied to git 2.12, I could see: >> >> Use of uninitialized value $batch_size in numeric eq (==) at >> /usr/lib/git-core/git-send-email line 1679 >> >> when --batch-size is

Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit

2017-05-16 Thread 赵小强
> 在 2017年5月16日,20:10,Jan Viktorin 写道: > > Hello, > > with this patch applied to git 2.12, I could see: > > Use of uninitialized value $batch_size in numeric eq (==) at > /usr/lib/git-core/git-send-email line 1679 > > when --batch-size is NOT used. See below... > > On Sat, 13 May 2017 09:57

Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit

2017-05-16 Thread Jan Viktorin
Hello, with this patch applied to git 2.12, I could see: Use of uninitialized value $batch_size in numeric eq (==) at /usr/lib/git-core/git-send-email line 1679 when --batch-size is NOT used. See below... On Sat, 13 May 2017 09:57:26 +0800 xiaoqiang zhao wrote: > Some email servers (e.g. smt

Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit

2017-05-14 Thread Junio C Hamano
xiaoqiang zhao writes: > Some email servers (e.g. smtp.163.com) limit the number emails to be > sent per session(connection) and this will lead to a faliure when > sending many messages. > > Teach send-email to disconnect after sending a number of messages > (configurable via the --batch-size= op

[PATCH v4] send-email: --batch-size to work around some SMTP server limit

2017-05-12 Thread xiaoqiang zhao
Some email servers (e.g. smtp.163.com) limit the number emails to be sent per session(connection) and this will lead to a faliure when sending many messages. Teach send-email to disconnect after sending a number of messages (configurable via the --batch-size= option), wait for a few seconds (confi