Re: [PATCH v4] rev-list: teach --no-object-names to enable piping

2019-06-19 Thread Jeff King
On Wed, Jun 19, 2019 at 12:31:34PM -0700, Emily Shaffer wrote: > > I noticed in range-diff, too. So now --object-names can be used > > with --pretty (not that "rev-list --pretty --objects" makes much > > sense in the first place, so no point in testing that it works). > > Yeah, it works. It look

Re: [PATCH v4] rev-list: teach --no-object-names to enable piping

2019-06-19 Thread Emily Shaffer
On Wed, Jun 19, 2019 at 07:08:14AM -0700, Junio C Hamano wrote: > Emily Shaffer writes: > > > Since v3, added a corresponding "--object-names" arg to pair with > > "--no-object-names", and "last-one-wins" logic. Also added a test to > > validate this new arg and the logic. > > Thanks for a quick

Re: [PATCH v4] rev-list: teach --no-object-names to enable piping

2019-06-19 Thread Junio C Hamano
Emily Shaffer writes: > Since v3, added a corresponding "--object-names" arg to pair with > "--no-object-names", and "last-one-wins" logic. Also added a test to > validate this new arg and the logic. Thanks for a quick turnaround (unfortunately, I was OOO yesterday and I am half-sick today, so p

[PATCH v4] rev-list: teach --no-object-names to enable piping

2019-06-18 Thread Emily Shaffer
Allow easier parsing by cat-file by giving rev-list an option to print only the OID of a non-commit object without any additional information. This is a short-term shim; later on, rev-list should be taught how to print the types of objects it finds in a format similar to cat-file's. Before this co