Re: [PATCH v4] refs.c: add a function to append a reflog entry to a fd

2014-11-20 Thread Junio C Hamano
Jonathan Nieder writes: > Stefan Beller wrote: > >> Signed-off-by: Ronnie Sahlberg >> Signed-off-by: Stefan Beller >> --- > [...] >> refs.c | 48 ++-- >> 1 file changed, 30 insertions(+), 18 deletions(-) > > The --patience diff makes review of this v

Re: [PATCH v4] refs.c: add a function to append a reflog entry to a fd

2014-11-20 Thread Jonathan Nieder
Stefan Beller wrote: > Signed-off-by: Ronnie Sahlberg > Signed-off-by: Stefan Beller > --- [...] > refs.c | 48 ++-- > 1 file changed, 30 insertions(+), 18 deletions(-) The --patience diff makes review of this version very simple. Reviewed-by: Jonat

[PATCH v4] refs.c: add a function to append a reflog entry to a fd

2014-11-20 Thread Stefan Beller
From: Ronnie Sahlberg Move code to create the string for a ref and write it to a file descriptor from log_ref_write and add it into a new dedicated function log_ref_write_fd. For now the new function is only used from log_ref_write, but later on we will call this function from reflog transaction