Re: [PATCH v4] reflog-walk: don't segfault on non-commit sha1's in the reflog

2016-01-06 Thread Duy Nguyen
On Wed, Jan 6, 2016 at 4:13 PM, Dennis Kaarsemaker wrote: > On di, 2016-01-05 at 20:52 -0500, Eric Sunshine wrote: >> On Tue, Jan 5, 2016 at 8:28 PM, Eric Sunshine < >> sunsh...@sunshineco.com> wrote: >> > On Tue, Jan 5, 2016 at 8:20 PM, Dennis Kaarsemaker >> > wrote: >> > > On di, 2016-01-05 at

Re: [PATCH v4] reflog-walk: don't segfault on non-commit sha1's in the reflog

2016-01-06 Thread Dennis Kaarsemaker
On di, 2016-01-05 at 20:52 -0500, Eric Sunshine wrote: > On Tue, Jan 5, 2016 at 8:28 PM, Eric Sunshine < > sunsh...@sunshineco.com> wrote: > > On Tue, Jan 5, 2016 at 8:20 PM, Dennis Kaarsemaker > > wrote: > > > On di, 2016-01-05 at 20:05 -0500, Eric Sunshine wrote: > > > > Hmm, this test is succes

Re: [PATCH v4] reflog-walk: don't segfault on non-commit sha1's in the reflog

2016-01-05 Thread Eric Sunshine
On Tue, Jan 5, 2016 at 8:28 PM, Eric Sunshine wrote: > On Tue, Jan 5, 2016 at 8:20 PM, Dennis Kaarsemaker > wrote: >> On di, 2016-01-05 at 20:05 -0500, Eric Sunshine wrote: >>> Hmm, this test is successful for me on OS X even without the >>> reflog-walk.c changes applied. >>> >>> And this test ac

Re: [PATCH v4] reflog-walk: don't segfault on non-commit sha1's in the reflog

2016-01-05 Thread Eric Sunshine
On Tue, Jan 5, 2016 at 8:20 PM, Dennis Kaarsemaker wrote: > On di, 2016-01-05 at 20:05 -0500, Eric Sunshine wrote: >> On Tue, Jan 5, 2016 at 4:12 PM, Dennis Kaarsemaker >> > + git update-ref --create-reflog -m "Creating ref" \ >> > + refs/tests/tree-in-reflog HEAD && >> > +

Re: [PATCH v4] reflog-walk: don't segfault on non-commit sha1's in the reflog

2016-01-05 Thread Dennis Kaarsemaker
On di, 2016-01-05 at 20:05 -0500, Eric Sunshine wrote: > On Tue, Jan 5, 2016 at 4:12 PM, Dennis Kaarsemaker > wrote: > > git reflog (ab)uses the log machinery to display its list of log > > entries. To do so it must fake commit parent information for the > > log > > walker. > > > > For refs in re

Re: [PATCH v4] reflog-walk: don't segfault on non-commit sha1's in the reflog

2016-01-05 Thread Eric Sunshine
On Tue, Jan 5, 2016 at 4:12 PM, Dennis Kaarsemaker wrote: > git reflog (ab)uses the log machinery to display its list of log > entries. To do so it must fake commit parent information for the log > walker. > > For refs in refs/heads this is no problem, as they should only ever > point to commits.

[PATCH v4] reflog-walk: don't segfault on non-commit sha1's in the reflog

2016-01-05 Thread Dennis Kaarsemaker
git reflog (ab)uses the log machinery to display its list of log entries. To do so it must fake commit parent information for the log walker. For refs in refs/heads this is no problem, as they should only ever point to commits. Tags and other refs however can point to anything, thus their reflog m