Re: [PATCH v4] grep: fail if call could output and name is null

2019-05-28 Thread Junio C Hamano
Jonathan Nieder writes: > Emily Shaffer wrote: > >> Signed-off-by: Emily Shaffer >> Reviewed-by: Jonathan Nieder >> --- >> Since v3, only the commit message has changed. Reworked based on >> Jonathan Nieder's suggestions (with some modifications for readability). >> >> grep.c | 4 >> 1 fi

Re: [PATCH v4] grep: fail if call could output and name is null

2019-05-23 Thread Jonathan Nieder
Emily Shaffer wrote: > Signed-off-by: Emily Shaffer > Reviewed-by: Jonathan Nieder > --- > Since v3, only the commit message has changed. Reworked based on > Jonathan Nieder's suggestions (with some modifications for readability). > > grep.c | 4 > 1 file changed, 4 insertions(+) This is

[PATCH v4] grep: fail if call could output and name is null

2019-05-23 Thread Emily Shaffer
grep_source(), which performs much of the work for Git's grep library, allows passing an arbitrary struct grep_source which represents the text which grep_source() should search to match a pattern in the provided struct grep_opt. In most callers, the grep_source::name field is set to an appropriate