Re: [PATCH v4] format-patch --signature-file

2014-05-19 Thread Jeff King
On Sun, May 18, 2014 at 01:22:02PM -0700, Jeremiah Mahler wrote: > @@ -742,6 +743,8 @@ static int git_format_config(const char *var, const char > *value, void *cb) > } > if (!strcmp(var, "format.signature")) > return git_config_string(&signature, var, value); > + if

[PATCH v4] format-patch --signature-file

2014-05-18 Thread Jeremiah Mahler
Added option that allows a signature file to be used with format-patch so that signatures with newlines and other special characters can be easily included. $ git format-patch --signature-file ~/.signature -1 The config variable format.signaturefile is also provided so that it can be added by d

[PATCH v4] format-patch --signature-file

2014-05-18 Thread Jeremiah Mahler
v4 of patch to add format-patch --signature-file option. This revision includes more suggestions from Jeff King: - Added a format.signaturefile config option. - Fixed error messages, --signature and format.signature - Fixed error checking, dies if strbuf_read_file fails. - style: "cat