Jonathan Tan writes:
> Sorry for not looking at this sooner.
>
> Firstly, I'm not sure if this file should be named without the ".txt",
> like SubmittingPatches.
SubmittingPatches has historical baggage but this does not, so its
source can be left as .txt (alternatively we could have added .txt
> On Mon, May 06, 2019 at 03:28:44PM -0700, Jonathan Tan wrote:
> > Sorry for not looking at this sooner.
> >
> > Firstly, I'm not sure if this file should be named without the ".txt",
> > like SubmittingPatches.
>
> I should mention that during this change's life as a GitGitGadget PR,
> dscho p
On Mon, May 06, 2019 at 03:28:44PM -0700, Jonathan Tan wrote:
> Sorry for not looking at this sooner.
>
> Firstly, I'm not sure if this file should be named without the ".txt",
> like SubmittingPatches.
I should mention that during this change's life as a GitGitGadget PR,
dscho performed a revie
On Thu, May 02, 2019 at 07:11:04PM -0700, Phil Hord wrote:
> On Tue, Apr 23, 2019 at 12:35 PM Emily Shaffer
> wrote:
> >
> > This tutorial covers how to add a new command to Git and, in the
> > process, everything from cloning git/git to getting reviewed on the
> > mailing list. It's meant for ne
Sorry for not looking at this sooner.
Firstly, I'm not sure if this file should be named without the ".txt",
like SubmittingPatches.
As for my other comments below, the Makefile comment below is the only
one I feel strongly about; feel free to disagree with the rest (which I
think are subjective
On Tue, Apr 23, 2019 at 12:35 PM Emily Shaffer wrote:
>
> This tutorial covers how to add a new command to Git and, in the
> process, everything from cloning git/git to getting reviewed on the
> mailing list. It's meant for new contributors to go through
> interactively, learning the techniques ge
On Tue, Apr 30, 2019 at 11:59:23AM -0700, Josh Steadmon wrote:
> Just a couple typo fixes listed below:
>
Thanks for the review, Josh.
I'll hold these fixes locally until I either get something more
significant to fix or Junio asks for them before a merge to next, to
reduce spam to the list.
-
Just a couple typo fixes listed below:
On 2019.04.23 12:34, Emily Shaffer wrote:
[snip]
> +=== Implementation
> +
> +It's probably useful to do at least something besides printing out a string.
> +Let's start by having a look at everything we get.
> +
> +Modify your `cmd_psuh` implementation to d
This tutorial covers how to add a new command to Git and, in the
process, everything from cloning git/git to getting reviewed on the
mailing list. It's meant for new contributors to go through
interactively, learning the techniques generally used by the git/git
development community.
Signed-off-by
9 matches
Mail list logo
