Alex Henrie writes:
> On Mon, Sep 30, 2019 at 3:48 AM Junio C Hamano wrote:
>>
>> Alex Henrie writes:
>>
>> > Well, I admit that code clarity is somewhat subjective. To me it's not
>> > obvious that "if (q->nr <= j)" means "if the loop exited normally",
I agree that it is subjective, but "if c
On Mon, Sep 30, 2019 at 3:48 AM Junio C Hamano wrote:
>
> Alex Henrie writes:
>
> > Well, I admit that code clarity is somewhat subjective. To me it's not
> > obvious that "if (q->nr <= j)" means "if the loop exited normally",
>
> I actually do not have too much problem with this side of the
> eq
Alex Henrie writes:
> Well, I admit that code clarity is somewhat subjective. To me it's not
> obvious that "if (q->nr <= j)" means "if the loop exited normally",
I actually do not have too much problem with this side of the
equation. I however do see problem with squashing the two diff_q
calls
On Sun, Sep 29, 2019 at 7:36 PM Junio C Hamano wrote:
>
> Alex Henrie writes:
>
> > The condition "if (q->nr <= j)" checks whether the loop exited normally
> > or via a break statement. This check can be avoided by replacing the
> > jump out of the inner loop with a jump to the end of the outer l
Alex Henrie writes:
> The condition "if (q->nr <= j)" checks whether the loop exited normally
> or via a break statement. This check can be avoided by replacing the
> jump out of the inner loop with a jump to the end of the outer loop.
>
> With the break replaced by a goto, the two diff_q calls t
The condition "if (q->nr <= j)" checks whether the loop exited normally
or via a break statement. This check can be avoided by replacing the
jump out of the inner loop with a jump to the end of the outer loop.
With the break replaced by a goto, the two diff_q calls then can be
replaced with a sing
6 matches
Mail list logo
