On Thu, Mar 7, 2019 at 6:21 AM Junio C Hamano wrote:
> The change to this main function looks quite straight-forward. I am
> kind of surprised that a very low hanging fruit like this had survived
> without getting hit by parseopt a lot earlier ;-)
There are more (I guess we tag #leftovers nowada
On Wed, Mar 6, 2019 at 7:21 PM Junio C Hamano wrote:
> >
> > +When mixing `-m` and `-F` options, the commit log message will be
> > +composed in the order in which the options are given.
>
> It may be just me, but this new paragraph made me think that we can
> give at most one -m and one -F option
Brandon Richardson writes:
> @@ -23,6 +23,9 @@ Creates a new commit object based on the provided tree
> object and
> emits the new commit object id on stdout. The log message is read
> from the standard input, unless `-m` or `-F` options are given.
>
> +When mixing `-m` and `-F` options, the
Rather than parse options manually, which is both difficult to
read and error prone, parse options supplied to commit-tree
using the parse-options api.
It was discovered that the --no-gpg-sign option was documented
but not implemented in commit 70ddbd7767 (commit-tree: add missing
--gpg-sign flag,
4 matches
Mail list logo
