Re: [PATCH v4] branch.c: change install_branch_config() to use skip_prefix()

2014-03-03 Thread Guanglin Xu
Hi Eric, Yes, you're right. "!!" is comfortably concise and also idiomatic in Git sources. Thanks, Guanglin 2014-03-03 16:12 GMT+08:00 Eric Sunshine : > On Mon, Mar 3, 2014 at 1:36 AM, Guanglin Xu wrote: >> to avoid a magic code of 11. >> >> Helped-by: Sun He >> Helped-by: Eric Sunshine >> H

Re: [PATCH v4] branch.c: change install_branch_config() to use skip_prefix()

2014-03-03 Thread Eric Sunshine
On Mon, Mar 3, 2014 at 1:36 AM, Guanglin Xu wrote: > to avoid a magic code of 11. > > Helped-by: Sun He > Helped-by: Eric Sunshine > Helped-by: Jacopo Notarstefano > > Signed-off-by: Guanglin Xu > --- > > This is an implementation of the idea#2 of GSoC 2014 microproject. > > branch.c | 8

[PATCH v4] branch.c: change install_branch_config() to use skip_prefix()

2014-03-02 Thread Guanglin Xu
to avoid a magic code of 11. Helped-by: Sun He Helped-by: Eric Sunshine Helped-by: Jacopo Notarstefano Signed-off-by: Guanglin Xu --- This is an implementation of the idea#2 of GSoC 2014 microproject. branch.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/bran