Re: [PATCH v4] blame: add support for --[no-]progress option

2015-11-24 Thread Edmundo Carmona Antoranz
On Mon, Nov 23, 2015 at 11:57 PM, Torsten Bögershausen wrote: > Minor remark: The '*' should be close to the variable: "struct progress_info > *pi" Nice catch, Torsten. I had already caught it as the standard... that one slipped by. Was waiting for more comments to show up, but none so far so I'

Re: [PATCH v4] blame: add support for --[no-]progress option

2015-11-23 Thread Torsten Bögershausen
On 11/24/2015 02:07 AM, Edmundo Carmona Antoranz wrote: diff --git a/builtin/blame.c b/builtin/blame.c index 83612f5..1d43b52 100644 --- a/builtin/blame.c +++ b/builtin/blame.c @@ -28,6 +28,7 @@ #include "line-range.h" #include "line-log.h" #include "dir.h" +#include "progress.h" stati

Re: [PATCH v4] blame: add support for --[no-]progress option

2015-11-23 Thread Edmundo Carmona Antoranz
On Mon, Nov 23, 2015 at 7:07 PM, Edmundo Carmona Antoranz wrote: > { > struct rev_info *revs = sb->revs; > struct commit *commit = prio_queue_get(&sb->commits); > + struct progress_info *pi = NULL; Switched to using pointer to make it more elegant. -- To unsubscribe from t

[PATCH v4] blame: add support for --[no-]progress option

2015-11-23 Thread Edmundo Carmona Antoranz
* created struct progress_info in builtin/blame.c this struct holds the information used to display progress so that only one additional parameter is passed to found_guilty_entry(). * --[no-]progress option is also inherited by git-annotate. Signed-off-by: Edmundo Carmona Antoranz --- Doc