Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-04 Thread Marco Stornelli
2012/9/4 Junio C Hamano : > Marco Stornelli writes: > >> kernel, load the patch and send, really easy. So I don't think it's a >> regression, it's only a change in the work flow. > > Any change that forces the user to change an established work flow > supporteed by the existing tool we gave them _

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-04 Thread Junio C Hamano
Marco Stornelli writes: > kernel, load the patch and send, really easy. So I don't think it's a > regression, it's only a change in the work flow. Any change that forces the user to change an established work flow supporteed by the existing tool we gave them _is_ a regression, even if the person

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-04 Thread Marco Stornelli
Il 04/09/2012 17:49, Junio C Hamano ha scritto: Marco Stornelli writes: 2012/9/4 Junio C Hamano : I would expect, at least when you are responding to an existing message, some of them are filled already (and if so, I think appp.sh wants to know exactly how, for example, has RFC2047 quoting a

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-04 Thread Junio C Hamano
Marco Stornelli writes: > 2012/9/4 Junio C Hamano : > >> I would expect, at least when you are responding to an existing >> message, some of them are filled already (and if so, I think appp.sh >> wants to know exactly how, for example, has RFC2047 quoting already >> applied, or are we supposed to

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-04 Thread Marco Stornelli
2012/9/4 Junio C Hamano : > Marco Stornelli writes: > >> I don't have thunderbird now but actually it's really simple: >> >> Subject: >> To: >> Cc: >> $SEP > > The above is not a very useful "example" to advance this discussion, > I have to say. For one, where is your Oggetto? 1) Where is your O

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-04 Thread Junio C Hamano
Marco Stornelli writes: > I don't have thunderbird now but actually it's really simple: > > Subject: > To: > Cc: > $SEP The above is not a very useful "example" to advance this discussion, I have to say. For one, where is your Oggetto? Are these fields the only ones you will ever see? Are the

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-03 Thread Marco Stornelli
2012/9/3 Junio C Hamano : > Marco Stornelli writes: > >> I tried the Johannes's script, but it seems it doesn't work well with >> the pattern of format-patch (To: ,\n ,\n >> ). The multilines are not well managed. > > I am guessing that the reason why Jonahhes's "copy our headers out > with cont

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-03 Thread Junio C Hamano
Marco Stornelli writes: > I tried the Johannes's script, but it seems it doesn't work well with > the pattern of format-patch (To: ,\n ,\n > ). The multilines are not well managed. I am guessing that the reason why Jonahhes's "copy our headers out with continuation lines intact" approach does

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-03 Thread Marco Stornelli
Il 02/09/2012 22:42, Junio C Hamano ha scritto: Marco Stornelli writes: Il 01/09/2012 15:59, Johannes Sixt ha scritto: Look how you write: perl -e '... $ENV{'PATCHTMP'} ...' That is, perl actually sees this script: ... $ENV{PATCHTMP} ... (no quotes around PATCHTMP). That my be pe

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-03 Thread Marco Stornelli
2012/9/2 Junio C Hamano : > Marco Stornelli writes: > >> Il 01/09/2012 15:59, Johannes Sixt ha scritto: >> >>> Look how you write: >>> >>>perl -e '... $ENV{'PATCHTMP'} ...' >>> >>> That is, perl actually sees this script: >>> >>>... $ENV{PATCHTMP} ... >>> >>> (no quotes around PATCHTMP). T

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-02 Thread Junio C Hamano
Marco Stornelli writes: > Il 01/09/2012 15:59, Johannes Sixt ha scritto: > >> Look how you write: >> >>perl -e '... $ENV{'PATCHTMP'} ...' >> >> That is, perl actually sees this script: >> >>... $ENV{PATCHTMP} ... >> >> (no quotes around PATCHTMP). That my be perfectly valid perl, but is n

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-02 Thread Junio C Hamano
Marco Stornelli writes: >> I also wonder what would happen if To: and Cc: in the input were >> split into continuation lines, but that was already present in the > > Do you mean To: ,.\nCc: ,.? No, I meant "To: ,...\n \n". But see my response to J6t's message. -- To unsubscribe from thi

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-02 Thread Junio C Hamano
Johannes Sixt writes: > Am 31.08.2012 16:09, schrieb Marco Stornelli: >> +CCS=`perl -e 'local $/=undef; open FILE, $ENV{'PATCHTMP'}; $text=; >> +close FILE; $addr = $1 if $text =~ /Cc: (.*?(,\n .*?)*)\n/s; $addr =~ >> s/\n//g; >> +print $addr;'` > > The quoting is broken in this line (sq within

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-01 Thread Marco Stornelli
Il 01/09/2012 15:59, Johannes Sixt ha scritto: Am 01.09.2012 09:43, schrieb Marco Stornelli: Il 31/08/2012 23:35, Johannes Sixt ha scritto: Am 31.08.2012 16:09, schrieb Marco Stornelli: +CCS=`perl -e 'local $/=undef; open FILE, $ENV{'PATCHTMP'}; $text=; +close FILE; $addr = $1 if $text =~ /Cc:

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-01 Thread Johannes Sixt
Am 01.09.2012 09:43, schrieb Marco Stornelli: > Il 31/08/2012 23:35, Johannes Sixt ha scritto: >> Am 31.08.2012 16:09, schrieb Marco Stornelli: >>> +CCS=`perl -e 'local $/=undef; open FILE, $ENV{'PATCHTMP'}; >>> $text=; >>> +close FILE; $addr = $1 if $text =~ /Cc: (.*?(,\n .*?)*)\n/s; $addr >>> =~

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-01 Thread Marco Stornelli
Il 31/08/2012 19:08, Junio C Hamano ha scritto: Marco Stornelli writes: The current script has got the following problems: 1) It doesn't work if the language used by Thunderbird is not english; 2) The field To: filled by format-patch is not evaluated; 3) The field Cc: is loaded from Cc used i

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-01 Thread Marco Stornelli
Il 31/08/2012 23:35, Johannes Sixt ha scritto: Am 31.08.2012 16:09, schrieb Marco Stornelli: +CCS=`perl -e 'local $/=undef; open FILE, $ENV{'PATCHTMP'}; $text=; +close FILE; $addr = $1 if $text =~ /Cc: (.*?(,\n .*?)*)\n/s; $addr =~ s/\n//g; +print $addr;'` The quoting is broken in this line (s

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-08-31 Thread Johannes Sixt
Am 31.08.2012 16:09, schrieb Marco Stornelli: > +CCS=`perl -e 'local $/=undef; open FILE, $ENV{'PATCHTMP'}; $text=; > +close FILE; $addr = $1 if $text =~ /Cc: (.*?(,\n .*?)*)\n/s; $addr =~ > s/\n//g; > +print $addr;'` The quoting is broken in this line (sq within sq does not work). Am I correct

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-08-31 Thread Junio C Hamano
Marco Stornelli writes: > +PATCHTMP="${PATCH}.tmp" > + > +echo $MAILHEADER > $PATCHTMP > + > +export PATCHTMP > +CCS=`perl -e 'local $/=undef; open FILE, $ENV{'PATCHTMP'}; $text=; > +close FILE; $addr = $1 if $text =~ /Cc: (.*?(,\n .*?)*)\n/s; $addr =~ > s/\n//g; > +print $addr;'` > + > +TO=`per

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-08-31 Thread Junio C Hamano
Marco Stornelli writes: > The current script has got the following problems: > > 1) It doesn't work if the language used by Thunderbird is not english; > 2) The field To: filled by format-patch is not evaluated; > 3) The field Cc: is loaded from Cc used in the commit message > instead of using th

[PATCH v4] Thunderbird: fix appp.sh format problems

2012-08-31 Thread Marco Stornelli
The current script has got the following problems: 1) It doesn't work if the language used by Thunderbird is not english; 2) The field To: filled by format-patch is not evaluated; 3) The field Cc: is loaded from Cc used in the commit message instead of using the Cc field filled by format-patch in