Re: [PATCH v3 7/8] branch.c: use 'ref-filter' APIs

2015-08-24 Thread Karthik Nayak
On Mon, Aug 24, 2015 at 11:01 PM, Junio C Hamano wrote: > Karthik Nayak writes: > test_expect_success 'git branch shows badly named ref' ' cp .git/refs/heads/master .git/refs/heads/broken...ref && test_when_finished "rm -f .git/refs/heads/broken...ref" && -

Re: [PATCH v3 7/8] branch.c: use 'ref-filter' APIs

2015-08-24 Thread Junio C Hamano
Karthik Nayak writes: >>> test_expect_success 'git branch shows badly named ref' ' >>> cp .git/refs/heads/master .git/refs/heads/broken...ref && >>> test_when_finished "rm -f .git/refs/heads/broken...ref" && >>> - git branch >output && >>> + git branch 2>output && >>>

Re: [PATCH v3 7/8] branch.c: use 'ref-filter' APIs

2015-08-22 Thread Karthik Nayak
On Sat, Aug 22, 2015 at 9:21 PM, Christian Couder wrote: > On Sat, Aug 22, 2015 at 8:51 AM, Karthik Nayak wrote: >> >> The test t1430 'git branch shows badly named ref' has been changed to >> check the stderr for the warning regarding the broken ref. This is >> done as ref-filter throws a warning

Re: [PATCH v3 7/8] branch.c: use 'ref-filter' APIs

2015-08-22 Thread Christian Couder
On Sat, Aug 22, 2015 at 8:51 AM, Karthik Nayak wrote: > > The test t1430 'git branch shows badly named ref' has been changed to > check the stderr for the warning regarding the broken ref. This is > done as ref-filter throws a warning for broken refs rather than > directly printing them. [...] >

[PATCH v3 7/8] branch.c: use 'ref-filter' APIs

2015-08-21 Thread Karthik Nayak
Make 'branch.c' use 'ref-filter' APIs for iterating through refs sorting. This removes most of the code used in 'branch.c' replacing it with calls to the 'ref-filter' library. Make 'branch.c' use the 'filter_refs()' function provided by 'ref-filter' to filter out tags based on the options set. We