Re: [PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces

2017-11-04 Thread Thomas Adam
On Thu, Nov 02, 2017 at 07:10:17PM -0400, Antoine Beaupré wrote: > Actually, is there a standard way to do this in git with Perl > extensions? I know about "option verbosity N" but how should I translate > this into Perl? Carp? Warn? Log::Any? Log4perl? No, not really. From a quick glance at some

Re: [PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces

2017-11-02 Thread Antoine Beaupré
On 2017-11-02 22:31:02, Thomas Adam wrote: > On Thu, Nov 02, 2017 at 06:26:43PM -0400, Antoine Beaupré wrote: >> On 2017-11-02 22:18:07, Thomas Adam wrote: >> > Hi, >> > >> > On Thu, Nov 02, 2017 at 05:25:18PM -0400, Antoine Beaupré wrote: >> >> +print {*STDERR} "$#{$mw_pages} found in name

Re: [PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces

2017-11-02 Thread Eric Sunshine
On Thu, Nov 2, 2017 at 5:25 PM, Antoine Beaupré wrote: > Without this, the fetch process seems hanged while we fetch page > listings across the namespaces. Obviously, it should be possible to > silence this with -q, but that's an issue already present everywhere > in the code and should be fixed s

Re: [PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces

2017-11-02 Thread Thomas Adam
On Thu, Nov 02, 2017 at 06:26:43PM -0400, Antoine Beaupré wrote: > On 2017-11-02 22:18:07, Thomas Adam wrote: > > Hi, > > > > On Thu, Nov 02, 2017 at 05:25:18PM -0400, Antoine Beaupré wrote: > >> +print {*STDERR} "$#{$mw_pages} found in namespace > >> $local_namespace ($namespace_id)\n"; >

Re: [PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces

2017-11-02 Thread Antoine Beaupré
On 2017-11-02 22:18:07, Thomas Adam wrote: > Hi, > > On Thu, Nov 02, 2017 at 05:25:18PM -0400, Antoine Beaupré wrote: >> +print {*STDERR} "$#{$mw_pages} found in namespace $local_namespace >> ($namespace_id)\n"; > > How is this any different to using warn()? I appreciate you're using a >

Re: [PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces

2017-11-02 Thread Thomas Adam
Hi, On Thu, Nov 02, 2017 at 05:25:18PM -0400, Antoine Beaupré wrote: > +print {*STDERR} "$#{$mw_pages} found in namespace $local_namespace > ($namespace_id)\n"; How is this any different to using warn()? I appreciate you're using a globbed filehandle, but it seems superfluous to me. Ki

[PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces

2017-11-02 Thread Antoine Beaupré
Without this, the fetch process seems hanged while we fetch page listings across the namespaces. Obviously, it should be possible to silence this with -q, but that's an issue already present everywhere in the code and should be fixed separately: https://github.com/Git-Mediawiki/Git-Mediawiki/issue