Re: [PATCH v3 5/8] evolve: Add the change-table structure

2019-01-29 Thread Stefan Xenos
Works with me. I'll resubmit without the double casting next chance I have to work on it. My long-term plan for that struct was to use the memory pool for all allocations anyway. I think that should let me implement it without moving objects around, which will make their addresses stable. That shou

Re: [PATCH v3 5/8] evolve: Add the change-table structure

2019-01-29 Thread Junio C Hamano
Stefan Xenos writes: > Sorry, folks. I normally can't do any open source work on weekdays. > That also includes writing responses on the mailing list, so there > will normally be a week or two lag for me to iterate on this sort of > thing. > > Feel free to either include this fix or revert my pat

Re: [PATCH v3 5/8] evolve: Add the change-table structure

2019-01-28 Thread Stefan Xenos
Sorry, folks. I normally can't do any open source work on weekdays. That also includes writing responses on the mailing list, so there will normally be a week or two lag for me to iterate on this sort of thing. Feel free to either include this fix or revert my patch if there's a problem with it -

Re: [PATCH v3 5/8] evolve: Add the change-table structure

2019-01-28 Thread Johannes Schindelin
Hi Junio, On Mon, 28 Jan 2019, Johannes Schindelin wrote: > On Sun, 27 Jan 2019, sxe...@google.com wrote: > > > + new_item->util = (void*)index; > > This is not good. You are using a `long` here. The 80s called and want > their now-obsolete data types back. > > If you want a data type that c

Re: [PATCH v3 5/8] evolve: Add the change-table structure

2019-01-28 Thread Johannes Schindelin
Hi Stefan, I did not yet have time to study your proposal in detail, but hope to do so before the Contributor Summit so that I can have an informed opinion. Just one thing: On Sun, 27 Jan 2019, sxe...@google.com wrote: > From: Stefan Xenos > > A change table stores a list of changes, and supp

[PATCH v3 5/8] evolve: Add the change-table structure

2019-01-27 Thread sxenos
From: Stefan Xenos A change table stores a list of changes, and supports efficient lookup from a commit hash to the list of changes that reference that commit directly. It can be used to look up content commits or metacommits at the head of a change, but does not support lookup of commits refere