Re: [PATCH v3 5/6] commit-graph: implement file format version 2

2019-05-01 Thread Derrick Stolee
On 5/1/2019 3:12 PM, Ævar Arnfjörð Bjarmason wrote: > > OK, let's try that then, on top of this series: > > diff --git a/commit-graph.c b/commit-graph.c > index 5eebba6a0f..36c8cdb950 100644 > --- a/commit-graph.c > +++ b/commit-graph.c > @@ -1127,7 +1127,7 @@ int write_commit

Re: [PATCH v3 5/6] commit-graph: implement file format version 2

2019-05-01 Thread Ævar Arnfjörð Bjarmason
On Wed, May 01 2019, Derrick Stolee via GitGitGadget wrote: > 3. Git did not fail with error if the unused eighth byte was > non-zero, so we could not use that to indicate an incremental > file format without breaking compatibility across versions. This isn't new, I just missed this

[PATCH v3 5/6] commit-graph: implement file format version 2

2019-05-01 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The commit-graph file format had some shortcomings which we now correct: 1. The hash algorithm was determined by a single byte, instead of the 4-byte format identifier. 2. There was no way to update the reachability index we used. We currently only support gen