Re: [PATCH v3 5/5] commit: support commit.verbose and --no-verbose

2014-05-26 Thread Jeremiah Mahler
Caleb, On Mon, May 26, 2014 at 01:56:26PM -0500, Caleb Thompson wrote: > Add a new configuration variable commit.verbose to implicitly pass > `--verbose` to `git-commit`. Add `--no-verbose` to commit to negate that > setting. > > Signed-off-by: Caleb Thompson > --- > Documentation/config.txt

Re: [PATCH v3 5/5] commit: support commit.verbose and --no-verbose

2014-05-26 Thread Jeremiah Mahler
On Mon, May 26, 2014 at 03:39:55PM -0500, Caleb Thompson wrote: > The editors, `check-for-diff` and `check-for-no-diffs`, are grepping for > the output and lack thereof, respectively. ... > > > > It appears that these tests still aren't checking to see if the > > "verbose" output appears in the com

Re: [PATCH v3 5/5] commit: support commit.verbose and --no-verbose

2014-05-26 Thread Caleb Thompson
The editors, `check-for-diff` and `check-for-no-diffs`, are grepping for the output and lack thereof, respectively. On Mon, May 26, 2014 at 01:33:04PM -0700, Jeremiah Mahler wrote: > j > On Mon, May 26, 2014 at 01:56:26PM -0500, Caleb Thompson wrote: > > Add a new configuration variable commit.ver

Re: [PATCH v3 5/5] commit: support commit.verbose and --no-verbose

2014-05-26 Thread Jeremiah Mahler
j On Mon, May 26, 2014 at 01:56:26PM -0500, Caleb Thompson wrote: > Add a new configuration variable commit.verbose to implicitly pass > ... > +test_expect_success 'commit shows verbose diff with set commit.verbose=true' > ' > + echo morecontent >>file && > + git add file && > + test

[PATCH v3 5/5] commit: support commit.verbose and --no-verbose

2014-05-26 Thread Caleb Thompson
Add a new configuration variable commit.verbose to implicitly pass `--verbose` to `git-commit`. Add `--no-verbose` to commit to negate that setting. Signed-off-by: Caleb Thompson --- Documentation/config.txt | 5 + Documentation/git-commit.txt | 8 +++- builtin/