Re: [PATCH v3 4/6] add a test for semantic errors in config files

2014-07-28 Thread Matthieu Moy
Tanay Abhra writes: > On 7/28/2014 4:52 PM, Matthieu Moy wrote: >> Tanay Abhra writes: >> >>> +test_expect_success 'check line errors for malformed values' ' >>> + mv .git/config .git/config.old && >>> + test_when_finished "mv .git/config.old .git/config" && >>> + cat >.git/config <<-\EOF

Re: [PATCH v3 4/6] add a test for semantic errors in config files

2014-07-28 Thread Tanay Abhra
On 7/28/2014 4:52 PM, Matthieu Moy wrote: > Tanay Abhra writes: > >> +test_expect_success 'check line errors for malformed values' ' >> +mv .git/config .git/config.old && >> +test_when_finished "mv .git/config.old .git/config" && >> +cat >.git/config <<-\EOF && >> +[alias] >> +

Re: [PATCH v3 4/6] add a test for semantic errors in config files

2014-07-28 Thread Matthieu Moy
Tanay Abhra writes: > +test_expect_success 'check line errors for malformed values' ' > + mv .git/config .git/config.old && > + test_when_finished "mv .git/config.old .git/config" && > + cat >.git/config <<-\EOF && > + [alias] > + br > + EOF > + test_expect_cod

[PATCH v3 4/6] add a test for semantic errors in config files

2014-07-28 Thread Tanay Abhra
Semantic errors (for example, for alias.* variables NULL values are not allowed) in configuration files cause a die printing the line number and file name of the offending value. Add a test documenting that such errors cause a die printing the accurate line number and file name. Signed-off-by: Ta