On Wed, May 31, 2017 at 08:29:43PM -0700, Joel Teichroeb wrote:
> I'm running into a lot of trouble using argv_array_clear. It seems
> that some of the builtin git cmd functions move the parameters around,
> and write new pointers to argv. There's three options I have now, and
> I'm not sure which
I'm running into a lot of trouble using argv_array_clear. It seems
that some of the builtin git cmd functions move the parameters around,
and write new pointers to argv. There's three options I have now, and
I'm not sure which is the best one.
1. Fix all the builtin cmd functions that I use to not
On Mon, May 29, 2017 at 8:18 PM, Joel Teichroeb wrote:
> Once I have all those leaks fixed, is there a way to make sure I'm not
> missing any? I tried using valgrind with leak-check enabled, but there
> are too many leaks from other git commands.
I just used:
valgrind --leak-check=full ./git
Once I have all those leaks fixed, is there a way to make sure I'm not
missing any? I tried using valgrind with leak-check enabled, but there
are too many leaks from other git commands.
Joel
Joel Teichroeb writes:
> +int untracked_files(struct strbuf *out, int include_untracked,
> + const char **argv)
Does this need to be public?
For a caller that wants to learn if there is _any_ untracked file,
having a strbuf that holds all output is overkill. For a caller
that wan
On Sun, May 28, 2017 at 11:31:48AM -0700, Joel Teichroeb wrote:
> >> + /* TODO: Improve this logic */
> >> + strbuf_addf(&symbolic, "%s", REV);
> >> + str = strstr(symbolic.buf, "@");
> >
> > Could you elaborate on how this should be improved?
>
> I just figured there would be a
On Sun, May 28, 2017 at 08:51:07PM +0200, Ævar Arnfjörð Bjarmason wrote:
> On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb wrote:
> > Implement all git stash functionality as a builtin command
> >
> > Signed-off-by: Joel Teichroeb
> > ---
>
> General note on this that I missed in my first E-Mai
On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb wrote:
> Implement all git stash functionality as a builtin command
>
> Signed-off-by: Joel Teichroeb
> ---
General note on this that I missed in my first E-Mail, you have ~20
calls to argv_array_init() but none to argv_array_clear(). So you're
lea
On Sun, May 28, 2017 at 11:26 AM, Ævar Arnfjörð Bjarmason
wrote:
> On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb wrote:
>> Implement all git stash functionality as a builtin command
>
> First thanks for working on this, it's great. Applied it locally,
> passes all tests for me. A couple of comm
On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb wrote:
> Implement all git stash functionality as a builtin command
First thanks for working on this, it's great. Applied it locally,
passes all tests for me. A couple of comments Christian didn't cover
> + info->has_u = get_sha1_with_context
On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb wrote:
[...]
> +int untracked_files(struct strbuf *out, int include_untracked,
> + const char **argv)
> +{
> + struct child_process cp = CHILD_PROCESS_INIT;
> + cp.git_cmd = 1;
> + argv_array_push(&cp.args, "ls-files
Implement all git stash functionality as a builtin command
Signed-off-by: Joel Teichroeb
---
Makefile |2 +-
builtin.h |1 +
builtin/stash.c | 1280 +
git-stash.
12 matches
Mail list logo
