Re: [PATCH v3 4/3] read-cache: don't try to write index if we can't write shared index

2018-01-14 Thread Thomas Gummerer
On 01/14, Duy Nguyen wrote: > On Sun, Jan 14, 2018 at 5:37 AM, Thomas Gummerer wrote: > > In a0a967568e ("update-index --split-index: do not split if $GIT_DIR is > > read only", 2014-06-13), we tried to make sure we can still write an > > index, even if the shared index can not be written. > > > >

Re: [PATCH v3 4/3] read-cache: don't try to write index if we can't write shared index

2018-01-14 Thread Duy Nguyen
On Sun, Jan 14, 2018 at 5:37 AM, Thomas Gummerer wrote: > In a0a967568e ("update-index --split-index: do not split if $GIT_DIR is > read only", 2014-06-13), we tried to make sure we can still write an > index, even if the shared index can not be written. > > We did so by just calling 'do_write_loc

[PATCH v3 4/3] read-cache: don't try to write index if we can't write shared index

2018-01-13 Thread Thomas Gummerer
In a0a967568e ("update-index --split-index: do not split if $GIT_DIR is read only", 2014-06-13), we tried to make sure we can still write an index, even if the shared index can not be written. We did so by just calling 'do_write_locked_index()' from 'write_shared_index()'. 'do_write_locked_index(