Re: [PATCH v3 3/5] commit test: Use write_script

2014-05-27 Thread Junio C Hamano
Eric Sunshine writes: >> -cat >check-for-diff <> -#!$SHELL_PATH >> -exec grep '^diff --git' "\$1" >> +write_script check-for-diff <<-EOF >> + exec grep '^diff --git' "\$1" > > Food for thought: > > The original code used < evaluated at script creation time, and took special care to escape $

Re: [PATCH v3 3/5] commit test: Use write_script

2014-05-27 Thread Eric Sunshine
On Mon, May 26, 2014 at 2:56 PM, Caleb Thompson wrote: > Use write_script from t/test-lib-functions instead of cat, shebang, and > chmod. > > Signed-off-by: Caleb Thompson > --- > t/t7507-commit-verbose.sh | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/t/t7507-com

[PATCH v3 3/5] commit test: Use write_script

2014-05-26 Thread Caleb Thompson
Use write_script from t/test-lib-functions instead of cat, shebang, and chmod. Signed-off-by: Caleb Thompson --- t/t7507-commit-verbose.sh | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh index 3b06d73..e62d921 100755