Re: [PATCH v3 3/3] git-p4: fix Git LFS pointer parsing

2016-04-25 Thread Sebastian Schuberth
On Mon, Apr 25, 2016 at 9:33 AM, Lars Schneider wrote: >> if you're omitting lines from the output. Also, the regex matches >> against the whole multi-line string. That is, if the file for some >> reason was ending in '\n\n' instead of just '\n', the '.*' would match >> almost all content of the

Re: [PATCH v3 3/3] git-p4: fix Git LFS pointer parsing

2016-04-25 Thread Lars Schneider
On 24 Apr 2016, at 21:16, Sebastian Schuberth wrote: > On Sun, Apr 24, 2016 at 8:58 PM, wrote: > >> --- a/git-p4.py >> +++ b/git-p4.py >> @@ -1064,8 +1064,15 @@ class GitLFS(LargeFileSystem): >> if pointerProcess.wait(): >> os.remove(contentFile) >> die('git-lf

Re: [PATCH v3 3/3] git-p4: fix Git LFS pointer parsing

2016-04-24 Thread Sebastian Schuberth
On Sun, Apr 24, 2016 at 8:58 PM, wrote: > --- a/git-p4.py > +++ b/git-p4.py > @@ -1064,8 +1064,15 @@ class GitLFS(LargeFileSystem): > if pointerProcess.wait(): > os.remove(contentFile) > die('git-lfs pointer command failed. Did you install the > extension?') >

[PATCH v3 3/3] git-p4: fix Git LFS pointer parsing

2016-04-24 Thread larsxschneider
From: Lars Schneider Git LFS 1.2.0 removed a preamble from the output of the 'git lfs pointer' command [1] which broke the parsing of this output. Adjust the parser to support the old and the new format. Please note that this patch slightly changes the second return parameter from a list of LF t