Re: [PATCH v3 2/9] Disallow diffopt.close_file when using the log_tree machinery

2016-06-22 Thread Johannes Schindelin
Hi Junio, On Tue, 21 Jun 2016, Junio C Hamano wrote: > Junio C Hamano writes: > > > Junio C Hamano writes: > > > >> Johannes Schindelin writes: > >> > >>> We are about to teach the log_tree machinery to reuse the diffopt.file > >>> setting to output to a file stream different from stdout. > >

Re: [PATCH v3 2/9] Disallow diffopt.close_file when using the log_tree machinery

2016-06-21 Thread Junio C Hamano
Junio C Hamano writes: > Junio C Hamano writes: > >> Johannes Schindelin writes: >> >>> We are about to teach the log_tree machinery to reuse the diffopt.file >>> setting to output to a file stream different from stdout. >>> >>> This means that builtin am can no longer ask the diff machinery to

Re: [PATCH v3 2/9] Disallow diffopt.close_file when using the log_tree machinery

2016-06-21 Thread Junio C Hamano
Junio C Hamano writes: > Johannes Schindelin writes: > >> We are about to teach the log_tree machinery to reuse the diffopt.file >> setting to output to a file stream different from stdout. >> >> This means that builtin am can no longer ask the diff machinery to >> close the file when actually c

Re: [PATCH v3 2/9] Disallow diffopt.close_file when using the log_tree machinery

2016-06-21 Thread Junio C Hamano
Johannes Schindelin writes: > We are about to teach the log_tree machinery to reuse the diffopt.file > setting to output to a file stream different from stdout. > > This means that builtin am can no longer ask the diff machinery to > close the file when actually calling the log_tree machinery (wh

[PATCH v3 2/9] Disallow diffopt.close_file when using the log_tree machinery

2016-06-21 Thread Johannes Schindelin
We are about to teach the log_tree machinery to reuse the diffopt.file setting to output to a file stream different from stdout. This means that builtin am can no longer ask the diff machinery to close the file when actually calling the log_tree machinery (which wants to flush the very same file s