Re: [PATCH v3 2/8] git_remote_helpers: fix input when running under Python 3

2013-02-05 Thread Erik Faye-Lund
On Fri, Jan 25, 2013 at 9:23 PM, Brandon Casey wrote: > On Wed, Jan 23, 2013 at 12:36 PM, Junio C Hamano wrote: >> Sverre Rabbelier writes: >> >>> On Wed, Jan 23, 2013 at 11:47 AM, John Keeping wrote: > When did we last revisit what minimal python version we are ok with > requiring? >>

Re: [PATCH v3 2/8] git_remote_helpers: fix input when running under Python 3

2013-01-25 Thread Brandon Casey
On Wed, Jan 23, 2013 at 12:36 PM, Junio C Hamano wrote: > Sverre Rabbelier writes: > >> On Wed, Jan 23, 2013 at 11:47 AM, John Keeping wrote: When did we last revisit what minimal python version we are ok with requiring? >>> >>> I was wondering if people would weigh in discussing that

Re: [PATCH v3 2/8] git_remote_helpers: fix input when running under Python 3

2013-01-23 Thread Junio C Hamano
Sverre Rabbelier writes: > On Wed, Jan 23, 2013 at 11:47 AM, John Keeping wrote: >>> When did we last revisit what minimal python version we are ok with >>> requiring? >> >> I was wondering if people would weigh in discussing that in response to >> [1] but no one has commented on that part of i

Re: [PATCH v3 2/8] git_remote_helpers: fix input when running under Python 3

2013-01-23 Thread Sverre Rabbelier
On Wed, Jan 23, 2013 at 11:47 AM, John Keeping wrote: >> When did we last revisit what minimal python version we are ok with >> requiring? > > I was wondering if people would weigh in discussing that in response to > [1] but no one has commented on that part of it. As another datapoint, > Brando

Re: [PATCH v3 2/8] git_remote_helpers: fix input when running under Python 3

2013-01-23 Thread John Keeping
On Wed, Jan 23, 2013 at 11:20:39AM -0800, Sverre Rabbelier wrote: > On Sun, Jan 20, 2013 at 5:15 AM, John Keeping wrote: > > Although 2to3 will fix most issues in Python 2 code to make it run under > > Python 3, it does not handle the new strict separation between byte > > strings and unicode stri

Re: [PATCH v3 2/8] git_remote_helpers: fix input when running under Python 3

2013-01-23 Thread Sverre Rabbelier
On Sun, Jan 20, 2013 at 5:15 AM, John Keeping wrote: > Although 2to3 will fix most issues in Python 2 code to make it run under > Python 3, it does not handle the new strict separation between byte > strings and unicode strings. There is one instance in > git_remote_helpers where we are caught by

[PATCH v3 2/8] git_remote_helpers: fix input when running under Python 3

2013-01-20 Thread John Keeping
Although 2to3 will fix most issues in Python 2 code to make it run under Python 3, it does not handle the new strict separation between byte strings and unicode strings. There is one instance in git_remote_helpers where we are caught by this, which is when reading refs from "git for-each-ref". Fi