Re: [PATCH v3 2/5] repo-settings: add feature.manyCommits setting

2019-08-01 Thread Derrick Stolee
On 7/31/2019 11:01 AM, Ævar Arnfjörð Bjarmason wrote: > > On Tue, Jul 30 2019, Derrick Stolee via GitGitGadget wrote: > >> +feature.*:: >> +The config settings that start with `feature.` modify the defaults of >> +a group of other config settings. These groups are created by the Git >> +

Re: [PATCH v3 2/5] repo-settings: add feature.manyCommits setting

2019-07-31 Thread Junio C Hamano
Johannes Schindelin writes: > On Tue, 30 Jul 2019, Junio C Hamano wrote: > >> "Derrick Stolee via GitGitGadget" writes: >> >> > +#define UPDATE_DEFAULT(s,v) do { if (s == -1) { s = v; } } while(0) >> >> [...] >> 3. When we learn to set default values for variables that are not >> boolean in

Re: [PATCH v3 2/5] repo-settings: add feature.manyCommits setting

2019-07-31 Thread Ævar Arnfjörð Bjarmason
On Tue, Jul 30 2019, Derrick Stolee via GitGitGadget wrote: > +feature.*:: > + The config settings that start with `feature.` modify the defaults of > + a group of other config settings. These groups are created by the Git > + developer community as recommended defaults and are subje

Re: [PATCH v3 2/5] repo-settings: add feature.manyCommits setting

2019-07-31 Thread Johannes Schindelin
Hi Junio, On Tue, 30 Jul 2019, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" writes: > > > +#define UPDATE_DEFAULT(s,v) do { if (s == -1) { s = v; } } while(0) > > [...] > 3. When we learn to set default values for variables that are not > boolean in the future, we will regret t

Re: [PATCH v3 2/5] repo-settings: add feature.manyCommits setting

2019-07-30 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > diff --git a/Documentation/config/feature.txt > b/Documentation/config/feature.txt > new file mode 100644 > index 00..f74314ae90 > --- /dev/null > +++ b/Documentation/config/feature.txt > @@ -0,0 +1,15 @@ > +feature.*:: > +... > +* `gc.writeCom

[PATCH v3 2/5] repo-settings: add feature.manyCommits setting

2019-07-30 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee When a repo has many commits, it is helpful to write and read the commit-graph file. Future changes to Git may include new config settings that are beneficial in this scenario. Create the 'feature.manyCommits' config setting that changes the default values of 'core.commitGra