Re: [PATCH v3 2/3] submodule--helper: teach config subcommand --unset

2019-02-07 Thread Junio C Hamano
Denton Liu writes: > + if (argc == 3 || (argc == 2 && command == DO_UNSET)) { > if (!is_writing_gitmodules_ok()) > die(_("please make sure that the .gitmodules file is in > the working tree")); > > - return config_set_in_gitmodules_file_gentl

Re: [PATCH v3 2/3] submodule--helper: teach config subcommand --unset

2019-02-07 Thread Junio C Hamano
Denton Liu writes: > This teaches submodule--helper config the --unset option, which removes > the specified configuration key from the .gitmodule file. > > Signed-off-by: Denton Liu > --- > builtin/submodule--helper.c | 18 -- > t/t7411-submodule-config.sh | 9 + > 2 f

[PATCH v3 2/3] submodule--helper: teach config subcommand --unset

2019-02-07 Thread Denton Liu
This teaches submodule--helper config the --unset option, which removes the specified configuration key from the .gitmodule file. Signed-off-by: Denton Liu --- builtin/submodule--helper.c | 18 -- t/t7411-submodule-config.sh | 9 + 2 files changed, 21 insertions(+), 6 de