Re: [PATCH v3 17/24] read-cache: read cache-tree in index-v5

2013-11-25 Thread Thomas Gummerer
Duy Nguyen writes: > On Mon, Aug 19, 2013 at 2:42 AM, Thomas Gummerer wrote: >> +/* >> + * This function modifies the directory argument that is given to it. >> + * Don't use it if the directory entries are still needed after. >> + */ > > There goes my hope of keeping directory_entry* in core so

Re: [PATCH v3 17/24] read-cache: read cache-tree in index-v5

2013-08-23 Thread Duy Nguyen
On Mon, Aug 19, 2013 at 2:42 AM, Thomas Gummerer wrote: > +/* > + * This function modifies the directory argument that is given to it. > + * Don't use it if the directory entries are still needed after. > + */ There goes my hope of keeping directory_entry* in core so that at write-time, after val

[PATCH v3 17/24] read-cache: read cache-tree in index-v5

2013-08-18 Thread Thomas Gummerer
Since the cache-tree data is saved as part of the directory data, we already read it at the beginning of the index. The cache-tree is only converted from this directory data. The cache-tree data is arranged in a tree, with the children sorted by pathlen at each node, while the ondisk format is sor