Re: [PATCH v3 12/24] cache-tree: share code between functions writing an index as a tree

2019-08-16 Thread Elijah Newren
On Fri, Aug 16, 2019 at 3:01 PM Junio C Hamano wrote: > > Elijah Newren writes: > > > write_tree_from_memory() appeared to be a merge-recursive special that > > basically duplicated write_index_as_tree(). The two have a different > > signature, but the bigger difference was just that write_index

Re: [PATCH v3 12/24] cache-tree: share code between functions writing an index as a tree

2019-08-16 Thread Junio C Hamano
Elijah Newren writes: > write_tree_from_memory() appeared to be a merge-recursive special that > basically duplicated write_index_as_tree(). The two have a different > signature, but the bigger difference was just that write_index_as_tree() > would always unconditionally read the index off of di

[PATCH v3 12/24] cache-tree: share code between functions writing an index as a tree

2019-08-15 Thread Elijah Newren
write_tree_from_memory() appeared to be a merge-recursive special that basically duplicated write_index_as_tree(). The two have a different signature, but the bigger difference was just that write_index_as_tree() would always unconditionally read the index off of disk instead of working on the cur