Re: [PATCH v3 11/20] path: construct correct path to a worktree's index

2017-06-21 Thread Junio C Hamano
Jonathan Nieder writes: > Brandon Williams wrote: > >> So your suggestion is to completely avoid doing any location when asking >> for a worktree_git_path, I guess those code paths which request those >> paths should be aware enough that if they need something in commondir to >> use git_common_pa

Re: [PATCH v3 11/20] path: construct correct path to a worktree's index

2017-06-21 Thread Jonathan Nieder
Brandon Williams wrote: > So your suggestion is to completely avoid doing any location when asking > for a worktree_git_path, I guess those code paths which request those > paths should be aware enough that if they need something in commondir to > use git_common_path instead. My only worry is tha

Re: [PATCH v3 11/20] path: construct correct path to a worktree's index

2017-06-21 Thread Brandon Williams
On 06/20, Jonathan Nieder wrote: > Hi again, > > Brandon Williams wrote: > > > When working with worktrees the git directory is split into two part, > > the per-worktree gitdir and a commondir which contains things which are > > shared among all worktrees (like the object store). With this notio

Re: [PATCH v3 11/20] path: construct correct path to a worktree's index

2017-06-20 Thread Jonathan Nieder
Subject: worktree_git_path() should not use file relocation git_path is a convenience function that usually produces a string $GIT_DIR/. Since v2.5.0-rc0~143^2~35 (git_path(): be aware of file relocation in $GIT_DIR, 2014-11-30), as a side benefit callers get support for path relocation variables

Re: [PATCH v3 11/20] path: construct correct path to a worktree's index

2017-06-20 Thread Jonathan Nieder
Hi again, Brandon Williams wrote: > When working with worktrees the git directory is split into two part, > the per-worktree gitdir and a commondir which contains things which are > shared among all worktrees (like the object store). With this notion of > having a split git directory, 557bd833b

Re: [PATCH v3 11/20] path: construct correct path to a worktree's index

2017-06-20 Thread Brandon Williams
On 06/20, Jonathan Nieder wrote: > Hi, > > Brandon Williams wrote: > > > When working with worktrees the git directory is split into two part, > > the per-worktree gitdir and a commondir which contains things which are > > shared among all worktrees (like the object store). With this notion of >

Re: [PATCH v3 11/20] path: construct correct path to a worktree's index

2017-06-20 Thread Jonathan Nieder
Hi, Brandon Williams wrote: > When working with worktrees the git directory is split into two part, > the per-worktree gitdir and a commondir which contains things which are > shared among all worktrees (like the object store). With this notion of > having a split git directory, 557bd833b (git_p

Re: [PATCH v3 11/20] path: construct correct path to a worktree's index

2017-06-20 Thread Stefan Beller
On Tue, Jun 20, 2017 at 12:19 PM, Brandon Williams wrote: > When working with worktrees the git directory is split into two part, > the per-worktree gitdir and a commondir which contains things which are > shared among all worktrees (like the object store). With this notion of > having a split gi

[PATCH v3 11/20] path: construct correct path to a worktree's index

2017-06-20 Thread Brandon Williams
When working with worktrees the git directory is split into two part, the per-worktree gitdir and a commondir which contains things which are shared among all worktrees (like the object store). With this notion of having a split git directory, 557bd833b (git_path(): be aware of file relocation in