Hi all, thanks for providing your feedback.
On Sun, Mar 15, 2015 at 6:14 AM, Junio C Hamano wrote:
> I am not sure if this is not a premature over-engineering---I am not
> convinced that such a future need will be fulfilled by passing just
> a single default_fn this version already passes, or it
Matthieu Moy writes:
> Junio C Hamano writes:
>
>> Paul Tan writes:
>>
I think you could even get away without passing default_fn here, and
just use the rule "the first file in the list is the default". Unless
you are anticipating ever passing something else, but I couldn't think
Junio C Hamano writes:
> Paul Tan writes:
>
>>> I think you could even get away without passing default_fn here, and
>>> just use the rule "the first file in the list is the default". Unless
>>> you are anticipating ever passing something else, but I couldn't think
>>> of a case where that would
Paul Tan writes:
>> I think you could even get away without passing default_fn here, and
>> just use the rule "the first file in the list is the default". Unless
>> you are anticipating ever passing something else, but I couldn't think
>> of a case where that would be useful.
>
> Even though in t
On Sat, Mar 14, 2015 at 01:33:28PM -0400, Jeff King wrote:
> On Sat, Mar 14, 2015 at 04:15:53PM +0800, Paul Tan wrote:
>
> > Even though in this case the store_credential() function is not used
> > anywhere else, from my personal API design experience I think that
> > cementing the rule of "the f
On Sat, Mar 14, 2015 at 04:15:53PM +0800, Paul Tan wrote:
> Even though in this case the store_credential() function is not used
> anywhere else, from my personal API design experience I think that
> cementing the rule of "the first file in the list is the default" in
> the behavior of the functio
On Fri, Mar 13, 2015 at 2:15 PM, Jeff King wrote:
>> +static void store_credential(const struct string_list *fns, struct
>> credential *c,
>> + const char *default_fn)
>
> I think you could even get away without passing default_fn here, and
> just use the rule "the first
On Wed, Mar 11, 2015 at 02:49:10PM +0800, Paul Tan wrote:
> Previously, git-credential-store only supported storing credentials in a
> single file: ~/.git-credentials. In order to support the XDG base
> directory specification[1], git-credential-store needs to be able to
> lookup and erase credent
Previously, git-credential-store only supported storing credentials in a
single file: ~/.git-credentials. In order to support the XDG base
directory specification[1], git-credential-store needs to be able to
lookup and erase credentials from multiple files, as well as to pick the
appropriate file t
9 matches
Mail list logo
